More accurate lint source location data; highlight/fail on deprecated terms#62
Closed
rvedotrc wants to merge 2 commits into
Closed
More accurate lint source location data; highlight/fail on deprecated terms#62rvedotrc wants to merge 2 commits into
rvedotrc wants to merge 2 commits into
Conversation
rvedotrc
changed the title
Contributor
|
Useful POC. It would be nice if we could have this as part of linting. Not sure how practical it is with the false positives. Is it possible to somehow mark "ignore" on certain linting issues if it is a false positive? 🤔 I'm going to close this PR for now as part of tidying up open PRs, but it's a useful reference we can come back if we decide to try the idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reports deprecated terms in markdown text (not code blocks, and not link targets), with nice accurate source code locations :-)
Matches on
classare not "fatal", i.e. not sufficient to fail the build, because there will be so many false positives.I have no idea if all this is even slightly useful.